<html>
<head><meta charset="utf-8"><title>github teams and access rights · t-lang/doc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/index.html">t-lang/doc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html">github teams and access rights</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="198917624"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198917624" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198917624">(May 27 2020 at 16:33)</a>:</h4>
<p>Let's start with something basic. Sorry I've put this off, but <span class="user-mention" data-user-id="120518">@Eric Huss</span> I think you said you can't merge PRs?</p>



<a name="198917689"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198917689" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198917689">(May 27 2020 at 16:34)</a>:</h4>
<p>I'd like to fix that :)</p>



<a name="198917718"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198917718" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198917718">(May 27 2020 at 16:34)</a>:</h4>
<p>so <a href="https://github.com/rust-lang/team/blob/master/teams/reference.toml">this team exists</a></p>



<a name="198917754"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198917754" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198917754">(May 27 2020 at 16:34)</a>:</h4>
<p>I guess that membership is still accurate? (cc <span class="user-mention" data-user-id="296643">@isHavvy</span> <span class="user-mention" data-user-id="116118">@Matthew Jasper</span>)</p>



<a name="198917782"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198917782" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198917782">(May 27 2020 at 16:34)</a>:</h4>
<p>I will sync it with a github team and give that team ownership over the ref I think</p>



<a name="198923572"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198923572" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198923572">(May 27 2020 at 17:19)</a>:</h4>
<p>Yes.  To be clear, the lead/member distinction is a bit fuzzy (with some context in <a href="https://github.com/rust-lang/team/pull/307">https://github.com/rust-lang/team/pull/307</a>), as there wasn't much discussion at the time (nobody asked me to be lead).  </p>
<p>The permission issue is that I can't merge my own PRs (I can merge other PRs).  And that's a bigger question of whether or not I <em>should</em>.  If my PRs can get merged by other people within a reasonable amount of time, it doesn't matter.  But if it takes weeks or months for small changes, that's frustrating and demotivating.  Sometimes, I feel like it would make sense for me to just merge trivial changes like <a href="https://github.com/rust-lang/reference/pull/811">https://github.com/rust-lang/reference/pull/811</a>.   I have other PRs open, which <em>I</em> think are correct, but should I be allowed to just merge them?</p>
<p>It won't help to sync the team with GitHub.  I already have write access.  The issue is that the repo is configured with branch protections, and "require reviewer", and GitHub won't allow you to approve your own PR.  Someone with admin access would need to remove those restrictions, or we should switch to bors.  I would kinda prefer bors, but I don't feel strongly about it.</p>



<a name="198942086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198942086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198942086">(May 27 2020 at 19:39)</a>:</h4>
<p>I think there's something to be said for "can't merge your own PR".</p>



<a name="198942190"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198942190" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198942190">(May 27 2020 at 19:40)</a>:</h4>
<p>We should absolutely solve the timeliness problem.</p>



<a name="198942224"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198942224" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198942224">(May 27 2020 at 19:40)</a>:</h4>
<p>(if we can)</p>



<a name="198951905"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198951905" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198951905">(May 27 2020 at 20:54)</a>:</h4>
<p>Well, regardless we should fix the github team, but I understand better now</p>



<a name="198951945"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198951945" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198951945">(May 27 2020 at 20:54)</a>:</h4>
<p>(i.e., we're trying to move away from individuals vs teams having access to repos in general)</p>



<a name="198957738"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/198957738" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> isHavvy <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#198957738">(May 27 2020 at 21:48)</a>:</h4>
<p>If you asked  a month ago, I'd say no, but if I ever get the energy to write anything, I'll definitely be writing for the reference again going forwards.</p>
<p>And if you have a trivial PR waiting on a reviewer, feel free to tag me on the PR.</p>



<a name="199247030"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/199247030" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#199247030">(May 30 2020 at 09:11)</a>:</h4>
<p><span class="user-mention silent" data-user-id="296643">isHavvy</span> <a href="#narrow/stream/237824-t-lang.2Fwg-reference/topic/github.20teams.20and.20access.20rights/near/198957738">said</a>:</p>
<blockquote>
<p>And if you have a trivial PR waiting on a reviewer, feel free to tag me on the PR.</p>
</blockquote>
<p>same here. I dont think I actually have any powers in that repo though, but I can at least give you feedback.</p>



<a name="200306830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/200306830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#200306830">(Jun 10 2020 at 00:11)</a>:</h4>
<p><span class="user-mention" data-user-id="296643">@isHavvy</span> A couple more small PRs waiting for review: <a href="https://github.com/rust-lang/reference/pull/815">https://github.com/rust-lang/reference/pull/815</a>  <a href="https://github.com/rust-lang/reference/pull/824">https://github.com/rust-lang/reference/pull/824</a>   Let me know if you have any questions or if I can clarify anything.</p>



<a name="200392912"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/237824-t-lang/doc/topic/github%20teams%20and%20access%20rights/near/200392912" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> isHavvy <a href="https://rust-lang.github.io/zulip_archive/stream/237824-t-lang/doc/topic/github.20teams.20and.20access.20rights.html#200392912">(Jun 10 2020 at 09:08)</a>:</h4>
<p>They look good. They somehow slipped past my notice. I don't remember even getting an email for them.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>